Messages in this thread | | | Date | Thu, 22 Apr 2010 09:09:19 +0300 | Subject | Re: [PATCH 2.6.34-rc1] proc: fix badness in fs/proc/generic.c | From | Alexey Dobriyan <> |
| |
On Thu, Apr 22, 2010 at 7:10 AM, GuanJun He <heguanbo@gmail.com> wrote: > fix badness in fs/proc/generic.c, Bug 15589 - 2.6.34-rc1: Badness at > fs/proc/generic.c:316 > this is just to get least waste.
This is already fixed by powerpc folks, I believe. Without memory leak.
> --- linux-2.6.34-rc1.orig/fs/proc/generic.c > +++ linux-2.6.34-rc1/fs/proc/generic.c > @@ -313,7 +313,15 @@ static int __xlate_proc_name(const char > break; > } > if (!de) { > - WARN(1, "name '%s'\n", name); > + char *dup = kstrdup(name, GFP_KERNEL); > + if (dup) { > + cp = dup; > + while(*dup) { > + if (*dup == '/') > + *dup++ = '_'; > + } > + WARN(1, "name '%s'\n", cp); > + } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |