Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 21 Apr 2010 14:55:52 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] max732x: Correct nr_port checking off by one error |
| |
On Mon, 12 Apr 2010 15:29:16 +0800 Axel Lin <axel.lin@gmail.com> wrote:
> Setup both client_group_a and client_group_b if nr_port > 8 (not > including nr_port==8). >
OK, that's what the patch does. But why does it do it?
In other words, when fixing a bug, please include a description of that bug! And, if it's not obvious from the description, please also describe the user-visible effects of that bug. So the poor schmuck at the other end (ie: me) can work out which kernel(s) the fix should be merged into.
> > diff --git a/drivers/gpio/max732x.c b/drivers/gpio/max732x.c > index f786824..51b02c6 100644 > --- a/drivers/gpio/max732x.c > +++ b/drivers/gpio/max732x.c > @@ -285,14 +285,14 @@ static int __devinit max732x_probe(struct > i2c_client *client,
The patch is wordwrapped.
> switch (client->addr & 0x70) { > case 0x60: > chip->client_group_a = client; > - if (nr_port > 7) { > + if (nr_port > 8) {
And has its tabs replaced with spaces. sorry-youre-using-gmail.
Please see if you can get that fixed up for next time (Documentation/email-clients.txt has some tips). Worst-case, use text/plain attachments.
Thanks.
| ![\](/images/icornerr.gif) |