Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 21 Apr 2010 12:12:14 -0700 | From | Divy Le Ray <> | Subject | Re: [PATCH] cxgb3: fix linkup issue |
| |
Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > I encountered an issue that not to link up on cxgb3 fabric. > I bisected and found that this regression was introduced by > 0f07c4ee8c800923ae7918c231532a9256233eed. > > Correct to pass phy_addr to cphy_init() at t3_xaui_direct_phy_prep(). > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> >
Sorry for the review delay, I just came back from some time off. Acked-by: Divy Le Ray <divy@chelsio.com>
> --- > drivers/net/cxgb3/ael1002.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/cxgb3/ael1002.c b/drivers/net/cxgb3/ael1002.c > index 5248f9e..35cd367 100644 > --- a/drivers/net/cxgb3/ael1002.c > +++ b/drivers/net/cxgb3/ael1002.c > @@ -934,7 +934,7 @@ static struct cphy_ops xaui_direct_ops = { > int t3_xaui_direct_phy_prep(struct cphy *phy, struct adapter *adapter, > int phy_addr, const struct mdio_ops *mdio_ops) > { > - cphy_init(phy, adapter, MDIO_PRTAD_NONE, &xaui_direct_ops, mdio_ops, > + cphy_init(phy, adapter, phy_addr, &xaui_direct_ops, mdio_ops, > SUPPORTED_10000baseT_Full | SUPPORTED_AUI | SUPPORTED_TP, > "10GBASE-CX4"); > return 0; >
| ![\](/images/icornerr.gif) |