Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 22 Apr 2010 02:06:22 +0900 | Subject | Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages | From | Minchan Kim <> |
| |
On Wed, Apr 21, 2010 at 11:15 PM, Christoph Lameter <cl@linux-foundation.org> wrote: > On Tue, 20 Apr 2010, Mel Gorman wrote: > >> alloc_pages_exact_node() avoids a branch in a hot path that is checking for >> something the caller already knows. That's the reason it exists. > > We can avoid alloc_pages_exact_node() by making all callers of > alloc_pages_node() never use -1. -1 is ambiguous and only rarely will a > caller pass that to alloc_pages_node().
That's very reasonable to me. Then, we can remove alloc_pages_exact_node and nid < 0 check in alloc_pages_node at the same time.
Mel. Could you agree?
Firstly Tejun suggested this but I didn't got the point. Sorry for bothering you.
Okay. I will dive into this approach. Thanks for careful review, All.
> -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |