lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] mfd: WM8350: remove incorrect kfree
    Date
    The i2c_client received in probe() should not be kfree()'d.

    Signed-off-by: Rabin Vincent <rabin@rab.in>
    ---
    drivers/mfd/wm8350-i2c.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/drivers/mfd/wm8350-i2c.c b/drivers/mfd/wm8350-i2c.c
    index 65830f5..5fe5de1 100644
    --- a/drivers/mfd/wm8350-i2c.c
    +++ b/drivers/mfd/wm8350-i2c.c
    @@ -64,10 +64,8 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,
    int ret = 0;

    wm8350 = kzalloc(sizeof(struct wm8350), GFP_KERNEL);
    - if (wm8350 == NULL) {
    - kfree(i2c);
    + if (wm8350 == NULL)
    return -ENOMEM;
    - }

    i2c_set_clientdata(i2c, wm8350);
    wm8350->dev = &i2c->dev;
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2010-04-21 17:37    [W:3.796 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site