lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/14] mm,migration: Allow the migration of PageSwapCache pages
On Tue, 20 Apr 2010, Mel Gorman wrote:

> @@ -520,10 +521,12 @@ static int move_to_new_page(struct page *newpage, struct page *page)
> else
> rc = fallback_migrate_page(mapping, newpage, page);
>
> - if (!rc)
> - remove_migration_ptes(page, newpage);
> - else
> + if (rc) {
> newpage->mapping = NULL;
> + } else {
> + if (remap_swapcache)
> + remove_migration_ptes(page, newpage);
> + }

You are going to keep the migration ptes after the page has been unlocked?
Or is remap_swapcache true if its not a swapcache page?

Maybe you meant

if (!remap_swapcache)

?

> unlock_page(newpage);
>

>
> skip_unmap:
> if (!page_mapped(page))
> - rc = move_to_new_page(newpage, page);
> + rc = move_to_new_page(newpage, page, remap_swapcache);
>
> - if (rc)
> + if (rc && remap_swapcache)
> remove_migration_ptes(page, page);
> rcu_unlock:
>

Looks like you meant !remap_swapcache



\
 
 \ /
  Last update: 2010-04-21 16:33    [W:0.081 / U:1.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site