Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] trivial: make mmap_min_addr perms 600 | From | Eric Paris <> | Date | Wed, 21 Apr 2010 10:04:27 -0400 |
| |
On Wed, 2010-04-21 at 10:00 -0400, Kyle McMartin wrote: > Chuck points out that mmap_min_addr is 644... > > CAP_SYS_RAWIO will deny users read/write to the file, let's let them see > that this is intended. > > Signed-off-by: Kyle McMartin <kyle@redhat.com>
I'm fine with it. RAWIO was only really added to block writes as I recall, but I don't see a good reason normal users need to see this and blocking them with rwx perms first is a good idea.
Acked-by: Eric Paris <eparis@redhat.com>
James, do you want to pick up and push towards linus?
-Eric > --- > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 8686b0f..5868481 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1209,7 +1209,7 @@ static struct ctl_table vm_table[] = { > .procname = "mmap_min_addr", > .data = &dac_mmap_min_addr, > .maxlen = sizeof(unsigned long), > - .mode = 0644, > + .mode = 0600, > .proc_handler = mmap_min_addr_handler, > }, > #endif
| ![\](/images/icornerr.gif) |