Messages in this thread | | | Date | Wed, 21 Apr 2010 08:40:40 -0500 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH 3/3] p9auth: add p9auth driver |
| |
Quoting David Howells (dhowells@redhat.com): > Serge E. Hallyn <serue@us.ibm.com> wrote: > > > + if (ret == 0) > > + commit_creds(new); > > + else > > + abort_creds(new); > > + > > + return ret; > > If you make this: > > if (ret == 0) > return commit_creds(new); > abort_creds(new); > return ret; > > then gcc can tail-call commit_creds(), which is guaranteed to return 0. > > David
Ok, will do.
thanks, -serge
| |