Messages in this thread | | | Date | Wed, 21 Apr 2010 06:26:02 -0700 | From | "Justin P. Mattock" <> | Subject | Re: [PATCH] Whitespace Coding style fixes. |
| |
On 04/21/2010 12:34 AM, Joe Perches wrote: > On Wed, 2010-04-21 at 00:09 -0700, Justin P. Mattock wrote: >> On 04/21/2010 12:03 AM, Alexey Dobriyan wrote: >>> You screw up git-blame. >> how does this patch screw it up? > > Alexey just doesn't like whitespace patches. > > Whitespace patches don't really "screw up" git blame. > > git blame displays the current version of a file > with line-by-line commits and the date each line > was last modified. > > So whitespace changes make it harder to find which patch > introduced the last logical change for a particular line. > > A more interactive git blame with history backtracking > might help keep Alexey happier but who knows for sure... > >
ahh.. so after adding this patch, and committing it in my branch the doing git blame security/commoncap.c only shows something from James Morris instead of what my change had brought.
Alright I can see why it screws things up.. I'll not (L)indent the whole tree then...
Justin P. Mattock
| |