lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] enhanced reimplemention of the kfifo API
On Tue, Apr 20, 2010 at 10:35:47PM +0200, Stefani Seibold wrote:
> >
> > > This are the features which are currently not used in the kernel:
> > >
> > > kfifo_to_user()
> > > kfifo_from_user()
> > > kfifo_dma_....() macros
> > > kfifo_esize()
> > > kfifo_recsize()
> > > kfifo_put()
> > > kfifo_get()
> > > the fixed size record elements, exclude "unsigned char" fifo's and
> > > the variable size records fifo's
> >
> > If you have features that have no users, why add them? Do you think
> > that some drivers need/want these features?
> >
>
> Some developers ask me for this features, so i am a nice girl and
> implemented it. Especially the kfifo_to_user() and kfifo_from_user() was
> desired and is IMHO very useful.
>
> kfifo_put(), kfifo_get(), kfifo_esize() and kfifo_recsize() didn't coast
> anything, because there are only macros.
>
> Andrew agreed that we add this for a given time period, and have a look
> what happens. The code overhead is not to much.
>
> It is a chicken and egg problem: If we do not provide this features,
> nobody can use it and everyone will write it's own implementation.

Ok, fair enough.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-04-21 00:17    [W:0.060 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site