Messages in this thread | | | Date | Tue, 20 Apr 2010 13:26:16 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [RFC][BUGFIX][PATCH 2/2] memcg: fix file mapped underflow at migration (v3) |
| |
On Tue, 20 Apr 2010 13:20:50 +0900 Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> > > I have one concern for now. Reading the patch, the flag have influence on > > > only anonymous pages, so we'd better to note it and I feel it strange to > > > set(and clear) the flag of "old page" always(iow, even when !PageAnon) > > > in prepare_migration. > > > > > > > Hmm...Checking "Only Anon" is simpler ? > I just thought it was inconsistent that we always set/clear the bit about "old page", > while we set the bit about "new page" only in PageAnon case. > Ok, look into again.
> > It will have no meanings for migrating > > file caches, but it may have some meanings for easy debugging. > > I think "mark it always but it's used only for anonymous page" is reasonable > > (if it causes no bug.) > > > Anyway, I don't have any strong objection. > It's all right for me as long as it is well documented or commented. > Maybe I can post v4, today.
Thanks, -Kame
| |