lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] x86: correctly wire up the newuname system call
On Tue, Apr 20, 2010 at 05:31:02AM +0200, Christoph Hellwig wrote:
> Before commit e28cbf22933d0c0ccaf3c4c27a1a263b41f73859 64-bit x86 had
> a private implementation of sys_uname which was just called sys_uname,
> which other architectures used for the old uname. Due to some merge
> issues with the uname refactoring patches we ended up calling the
> old uname version for both the old and new system call slots, which
> lead to the domainname filed never be set which caused failures with
^^^^^ field.

> libnss_nis.
>
> Reported-by: Andy Isaacson <adi@hexapodia.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/arch/x86/ia32/ia32entry.S
> ===================================================================
> --- linux-2.6.orig/arch/x86/ia32/ia32entry.S 2010-04-19 20:21:11.919003961 -0700
> +++ linux-2.6/arch/x86/ia32/ia32entry.S 2010-04-19 20:21:19.902005565 -0700
> @@ -626,7 +626,7 @@ ia32_sys_call_table:
> .quad stub32_sigreturn
> .quad stub32_clone /* 120 */
> .quad sys_setdomainname
> - .quad sys_uname
> + .quad sys_newuname

Yes, that's the same patch I arrived at and fixes the issue for me.

Tested-by: Andy Isaacson <adi@hexapodia.org>

Thanks,
-andy


\
 
 \ /
  Last update: 2010-04-20 16:53    [W:0.070 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site