Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 2 Apr 2010 20:43:49 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] tty: release_one_tty() forgets to put pids |
| |
On 04/02, Linus Torvalds wrote: > > On Fri, 2 Apr 2010, Oleg Nesterov wrote: > > > > release_one_tty(tty) can be called when tty still has a reference > > to pgrp/session. In this case we leak the pid. > > Hmm. Maybe we should have cleared this in tty_release() already. We > already do some of the session clearing there (but we clear the session in > the _tasks_ associated with the tty, not the tty session pointer).
Yes, probably we can free them earlier.
But I am very nervous about this change, I tried to defer put_pid() as much as possible, in case something else uses ->prgp/session before free_tty_struct().
Oleg.
| ![\](/images/icornerr.gif) |