Messages in this thread | | | Date | Thu, 15 Apr 2010 08:56:15 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] blkio: Fix linux-next build failure after merge of block tree |
| |
On Wed, Apr 14 2010, Divyesh Shah wrote: > After merging the block tree, 20100414's linux-next build (x86_64 > allmodconfig) failed like this: > > ERROR: "get_gendisk" [block/blk-cgroup.ko] undefined! > ERROR: "sched_clock" [block/blk-cgroup.ko] undefined! > > This happens because the two symbols aren't exported and hence not available > when blk-cgroup code is built as a module. I've tried to stay consistent with > the use of EXPORT_SYMBOL or EXPORT_SYMBOL_GPL with the other symbols in the > respective files.
Thanks, applied. I changed the subject to say 'fix for modular blk-cgroup build', as that is a lot more descriptive than saying you fixed linux-next build. It's more informative to note the actual problem, not how it was discovered.
-- Jens Axboe
| |