Messages in this thread | | | Subject | Re: [PATCH] mac8390: fix pr_info() calls, was Re: another cleanup patch gone wrong | From | Joe Perches <> | Date | Thu, 15 Apr 2010 20:54:40 -0700 |
| |
On Fri, 2010-04-16 at 13:45 +1000, Finn Thain wrote: > Here's a patch, both uncalled-for and untested. > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > > --- a/drivers/net/mac8390.c 2010-04-16 13:31:04.000000000 +1000 > +++ b/drivers/net/mac8390.c 2010-04-16 13:35:06.000000000 +1000 > @@ -643,8 +643,8 @@ > { > __ei_open(dev); > if (request_irq(dev->irq, __ei_interrupt, 0, "8390 Ethernet", dev)) { > - pr_info("%s: unable to get IRQ %d.\n", dev->name, dev->irq); > - return -EAGAIN; > + pr_err("%s: unable to get IRQ %d.\n", dev->name, dev->irq); > + return -EBUSY;
You should document this in the changelog.
> } > return 0; > } > @@ -660,7 +660,7 @@ > { > ei_status.txing = 0; > if (ei_debug > 1) > - pr_info("reset not supported\n"); > + pr_debug("reset not supported\n");
You'll need to add #define DEBUG for this to print.
> - pr_info("Need to reset the NS8390 t=%lu...", jiffies); > + pr_debug("Need to reset the NS8390 t=%lu...", jiffies);
This also now doesn't print.
cheers, Joe
| |