Messages in this thread | | | Date | Thu, 15 Apr 2010 11:02:32 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 3/4] liss331d1: accelerometer driver |
| |
> Err. Anyone get a feeling of deja vu here? > > http://lists.lm-sensors.org/pipermail/lm-sensors/2009-September/026706.html > > When Kalhan originally posted this driver it was pointed out that it > was compatible with the existing one. A complete lack of > communications lead to Kalhan (and someone else, might have been Eric > or Samu, can't recall) both implementing i2c support in the driver. > Can't find it right now but I'm fairly sure Kahlan reported that > worked fine for this chip as well? > > So looks like a lack of communications here and that Alan has picked > up an unnecessary driver.
Thanks it does indeed - except for the retry logic which has come from another platform source and can be submitted in turn. Only other thing I see odd is that the existing driver prints a scary error message when there is no IRQ rather than just an info message.
Alan
| |