Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 15 Apr 2010 12:03:24 +0300 | From | "Michael S. Tsirkin" <> | Subject | Re: [RFC][PATCH v3 1/3] A device for zero-copy based on KVM virtio-net. |
| |
On Thu, Apr 15, 2010 at 05:01:10PM +0800, Xin, Xiaohui wrote: > >It smells like a layering violation to look at the iocb->private field > >from a lower-level driver. I would have hoped that it's possible to implement > >this without having this driver know about the higher-level vhost driver > >internals. Can you explain why this is needed? > > I don't like this too, but since the kiocb is maintained by vhost with a list_head. > And mp device is responsible to collect the kiocb into the list_head, > We need something known by vhost/mp both.
Can't vhost supply a kiocb completion callback that will handle the list?
-- MST
| ![\](/images/icornerr.gif) |