lkml.org 
[lkml]   [2010]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: TRACE_EVENT() declarations belong to include/trace/
From
Date
On Mon, 2010-04-12 at 17:45 -0400, Mathieu Desnoyers wrote:
> Hi,
>
> Ranting about:
>
> commit 1bf4af165050d90ea6659ffb2536ec8ca783aab5
> Author: Anton Blanchard <anton@samba.org>
> Date: Mon Oct 26 18:47:42 2009 +0000
>
> powerpc: tracing: Add powerpc tracepoints for interrupt entry and exit
>
> Why are there TRACE_EVENT() declarations in arch/powerpc/include/asm/trace.h for
> irq_entry/exit ?
>
> What's so special about them that they cannot be put in linux/trace/ ?
>
> I'm all for the trace_irq_entry/exit instrumentation, but I don't see any good
> in adding event declarations outside of include/trace/.


If there is any specific architecture data being recorded in the
TRACE_EVENT() macro, then it should be arch specific, but if not, then
it should go in include/trace/

/me goes to look at the code.

-- Steve



\
 
 \ /
  Last update: 2010-04-13 00:29    [W:0.027 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site