Messages in this thread | | | Date | Mon, 12 Apr 2010 07:41:59 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] Revert "memory-hotplug: add 0x prefix to HEX block_size_bytes" |
| |
On Thu 2010-04-08 23:41:24, Am?rico Wang wrote: > On Thu, Apr 08, 2010 at 05:10:06PM +0200, Heiko Carstens wrote: > >From: Heiko Carstens <heiko.carstens@de.ibm.com> > > > >Revert ba168fc37dea145deeb8fa9e7e71c748d2e00d74 "memory-hotplug: add 0x prefix > >to HEX block_size_bytes" since it changes the user space visible sysfs interface > >/sys/devices/system/memory/block_size_bytes. > >The change breaks existing user space applications which rely on the fact that > >the output does not contain the "0x" prefix. > > > > Odd. > > Which application relies on this? Isn't the application which should > be fixed?? It should use something like strtoul() which doesn't > rely on '0x' prefix.
'no regressions'?!
You should not randomly change kernel api, then blame it on applications. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |