Messages in this thread | | | Date | Sat, 10 Apr 2010 14:08:47 -0400 | Subject | Re: [PATCH] Staging: dream: smd: smd_qmi: fix code style issues | From | Chihau Chau <> |
| |
So, What about this patch? Greg?
2010/3/15 Pavel Machek <pavel@ucw.cz>: > On Mon 2010-03-15 00:44:54, Chihau Chau wrote: >> From: Chihau Chau <chihau@gmail.com> >> >> This fixes some code style issues about to #include <linux/uaccess.h> >> instead of <asm/uaccess.h> and some not necessary braces {}. >> >> Signed-off-by: Chihau Chau <chihau@gmail.com> > > ACK. > >> --- >> drivers/staging/dream/smd/smd_qmi.c | 7 +++---- >> 1 files changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/dream/smd/smd_qmi.c b/drivers/staging/dream/smd/smd_qmi.c >> index 687db14..9e9067f 100644 >> --- a/drivers/staging/dream/smd/smd_qmi.c >> +++ b/drivers/staging/dream/smd/smd_qmi.c >> @@ -25,7 +25,7 @@ >> #include <linux/miscdevice.h> >> #include <linux/workqueue.h> >> >> -#include <asm/uaccess.h> >> +#include <linux/uaccess.h> >> #include <mach/msm_smd.h> >> >> #define QMI_CTL 0x00 >> @@ -643,11 +643,10 @@ static int qmi_print_state(struct qmi_ctxt *ctxt, char *buf, int max) >> } >> >> i = scnprintf(buf, max, "STATE=%s\n", statename); >> - i += scnprintf(buf + i, max - i, "CID=%d\n",ctxt->wds_client_id); >> + i += scnprintf(buf + i, max - i, "CID=%d\n", ctxt->wds_client_id); >> >> - if (ctxt->state != STATE_ONLINE){ >> + if (ctxt->state != STATE_ONLINE) >> return i; >> - } >> >> i += scnprintf(buf + i, max - i, "ADDR=%d.%d.%d.%d\n", >> ctxt->addr[0], ctxt->addr[1], ctxt->addr[2], ctxt->addr[3]); > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html >
-- Chihau Chau -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |