lkml.org 
[lkml]   [2010]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add "nested" field to event of lock_release
On 04/10/10 22:59, Peter Zijlstra wrote:
> On Sat, 2010-04-10 at 19:41 +0900, Hitoshi Mitake wrote:
>> State machine of perf lock requires "nested" field of lock_release(),
>> so this patch adds it to event.
>>
>> Signed-off-by: Hitoshi Mitake<mitake@dcl.info.waseda.ac.jp>
>> Cc: Peter Zijlstra<a.p.zijlstra@chello.nl>
>> Cc: Paul Mackerras<paulus@samba.org>
>> Cc: Arnaldo Carvalho de Melo<acme@redhat.com>
>> Cc: Frederic Weisbecker<fweisbec@gmail.com>
>
> The nested flag only indicates if it could be nested, not if it was
> actually nested. So no, this doesn't make any sense at all.
>
> (in fact, pretty much every lock_release out there has nested=1)
>

Ah, sorry, I misunderstood.
When looked at rwlock_release(), I judged that nested is required,
because double or more read_lock() is allowed.

Thanks for your correction :)
Hitoshi


\
 
 \ /
  Last update: 2010-04-10 16:53    [W:0.043 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site