Messages in this thread | ![/](/images/icornerl.gif) | | From | Hans Verkuil <> | Subject | Re: [PATCH 12/24] media/video: fix dangling pointers | Date | Thu, 1 Apr 2010 10:32:50 +0200 |
| |
On Tuesday 30 March 2010 14:39:12 Wolfram Sang wrote: > Hans, > > > But this just feels like an i2c core thing to me. After remove() is called > > the core should just set the client data to NULL. If there are drivers that > > rely on the current behavior, then those drivers should be reviewed first as > > to the reason why they need it. > > It will be done this way now. As you have taken part in the discussion, I guess > the media-subsystem never really considered picking those patches up ;)
I remember that there was one patch in your patch series where the client data was set after it was freed.
That should still be fixed (by just removing the i2c_set_clientdata).
Can you post that one again?
Regards,
Hans
> > Regards, > > Wolfram > >
-- Hans Verkuil - video4linux developer - sponsored by TANDBERG
| ![\](/images/icornerr.gif) |