Messages in this thread | | | Date | Thu, 1 Apr 2010 13:03:59 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/3] can: add support for Janz VMOD-ICAN3 Intelligent CAN module |
| |
On Mon, 29 Mar 2010 09:58:51 -0700 "Ira W. Snyder" <iws@ovro.caltech.edu> wrote:
> The Janz VMOD-ICAN3 is a MODULbus daughterboard which fits onto any > MODULbus carrier board. It is an intelligent CAN controller with a > microcontroller and associated firmware. >
A neat-looking driver.
> ... > > + spin_lock_irqsave(&mod->lock, flags); > > ...
It does this rather a lot. it seems to be doing quite a lot of work under that lock, too - quite a lot of memcpy_toio(), other stuff.
Is there potential here to disable interrupt for too long? Not possible to use spin_lock_bh() here?
| |