Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 1 Apr 2010 19:32:58 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCHv5 3/4] tracing: graph output support for irqsoff tracer |
| |
On Thu, Apr 01, 2010 at 05:37:08PM +0200, Jiri Olsa wrote: > +static int start_irqsoff_tracer(struct trace_array *tr, int graph) > { > - register_ftrace_function(&trace_ops); > - if (tracing_is_enabled()) > + int ret = 0; > + > + if (!graph) > + ret = register_ftrace_function(&trace_ops); > +#ifdef CONFIG_FUNCTION_GRAPH_TRACER > + else > + ret = register_ftrace_graph(&irqsoff_graph_return, > + &irqsoff_graph_entry); > +#endif
Please rather define static inline stubs for register_ftrace_graph in linux/ftrace.h if !CONFIG_FUNCTION_GRAPH_TRACER
> + > + if (!ret && tracing_is_enabled()) > tracer_enabled = 1; > else > tracer_enabled = 0; > + > + return ret; > } > > -static void stop_irqsoff_tracer(struct trace_array *tr) > +static void stop_irqsoff_tracer(struct trace_array *tr, int graph) > { > tracer_enabled = 0; > - unregister_ftrace_function(&trace_ops); > + > + if (!graph) > + unregister_ftrace_function(&trace_ops); > +#ifdef CONFIG_FUNCTION_GRAPH_TRACER > + else > + unregister_ftrace_graph(); > +#endif
Same here.
Thanks.
| ![\](/images/icornerr.gif) |