Messages in this thread | ![/](/images/icornerl.gif) | | From | Frans Pop <> | Subject | Re: [PATCH] proc: Report file name on detected read_proc overflow | Date | Thu, 1 Apr 2010 16:41:56 +0200 |
| |
Jan Kiszka wrote: > - "proc_file_read: Apparent buffer overflow!\n"); > + "proc_file_read: Apparent buffer " > + "overflow reading \"%s\"!\n", > + file->f_path.dentry->d_name.name);
I think it would be good to keep "overflow" on the first line as that may be what people will grep the source for. And maybe use single quotes around the file name. So:
+ "proc_file_read: Apparent buffer overflow " + "reading '%s'!\n", + file->f_path.dentry->d_name.name);
Cheers, FJP
| ![\](/images/icornerr.gif) |