Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 9 Nov 2010 23:26:45 +0100 | From | Sascha Hauer <> | Subject | Re: [PATCHv3 2/2] ARM: imx: Add mx53 support to common msl functions. |
| |
On Tue, Nov 09, 2010 at 11:12:13PM +0100, Uwe Kleine-König wrote: > Hello, > > > > - if (!cpu_is_mx51()) > > > + if (!cpu_is_mx51() || !cpu_is_mx53()) > > > return 0; > > > > The code below runs for every SoC except i.MX51 and i.MX53. This is > > surely not what you want. > Hmm, for i.MX51 !cpu_is_mx53() is true, so the return 0 is always taken, > isn't it? :-)
Gna, I remember I ran in this trap not so long time ago ;)
Sascha
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |