lkml.org 
[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] clear PageError bit in msync & fsync
On Tue, Nov 09, 2010 at 02:33:29PM -0500, Rik van Riel wrote:
>
> There are essentially two possibilities:
> 1) the VM can potentially be filled up with uncleanable dirty pages, or
> 2) pages that hit an IO error are left in a clean state, so they can
> be reclaimed under memory pressure
>
> Alternative 1 could cause the entire system to deadlock, while
> option 2 puts the onus on userland apps to rewrite the data
> from a failed msync/fsync.
>
> Currently the VM has behaviour #2 which is preserved with my
> patch.
>
> The only difference with my patch is, we won't keep returning
> -EIO on subsequent, error free, msync or fsync calls to files
> that had an IO error at some previous point in the past.

Do we guarantee that the application will get EIO at least once? I
thought there were issues where the error bit could get lost if the
page writeback was triggered by sync() run by a third-party
application.


- Ted


\
 
 \ /
  Last update: 2010-11-09 22:09    [W:0.092 / U:4.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site