Messages in this thread | ![/](/images/icornerl.gif) | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH v2 17/23] kmsg_dumper: Introduce a new 'SOFT' dump reason | Date | Tue, 9 Nov 2010 14:54:52 +0900 (JST) |
| |
> Hi > > > It is a useful to be able to exercise kmsg_dumper implementations without > > requiring a kernel oops or panic. This commit adds a new reason called > > KMSG_DUMP_SOFT, which signifies that the system isn't really going down. > > > > This logic is used in a later commit that introduces the netoops driver. > > > > Signed-off-by: Mike Waychison <mikew@google.com> > > --- > > > > It is also possible that we not introduce KMSG_DUMP_SOFT, and simply overload > > the existing KMSG_DUMP_OOPS reason, but I figured that this would be cleaner. > > > > TODO: Make sure mtdoops and ramoops do something useful with this flag? > > Yes. If userland explicitly want to log, we have no reason to refuse it. :)
I meant I think your change has no problem.
> But, I don't think KMSG_DUMP_SOFT is good name because _SOFT don't explain > anything.
| ![\](/images/icornerr.gif) |