Messages in this thread | | | Date | Tue, 9 Nov 2010 20:15:08 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH 6/6] memcg: make mem_cgroup_page_stat() return value unsigned |
| |
On Tue, Nov 09, 2010 at 05:24:31PM +0800, Greg Thelen wrote: > mem_cgroup_page_stat() used to return a negative page count > value to indicate value. > > mem_cgroup_page_stat() has changed so it never returns > error so convert the return value to the traditional page > count type (unsigned long). > > Signed-off-by: Greg Thelen <gthelen@google.com> > ---
> + /* > + * The sum of unlocked per-cpu counters may yield a slightly negative > + * value. This function returns an unsigned value, so round it up to > + * zero to avoid returning a very large value. > + */ > + if (value < 0) > + value = 0;
nitpick: it's good candidate for unlikely().
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
Sorry, I lose track to the source code after so many patches. It would help if you can put the patches to a git tree.
Thanks, Fengguang
| |