Messages in this thread | | | Subject | Re: [PATCH 08/17][trivial] scsi: Remove unnecessary casts of void ptr returning alloc function return values | From | Joe Perches <> | Date | Mon, 08 Nov 2010 15:34:26 -0800 |
| |
On Tue, 2010-11-09 at 00:09 +0100, Jesper Juhl wrote: > Signed-off-by: Jesper Juhl <jj@chaosbits.net> > diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c [] > @@ -4780,7 +4780,7 @@ ahc_init_scbdata(struct ahc_softc *ahc) > SLIST_INIT(&scb_data->sg_maps); > > /* Allocate SCB resources */ > - scb_data->scbarray = (struct scb *)kmalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, GFP_ATOMIC); > + scb_data->scbarray = kmalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, GFP_ATOMIC); > if (scb_data->scbarray == NULL) > return (ENOMEM); > memset(scb_data->scbarray, 0, sizeof(struct scb) * AHC_SCB_MAX_ALLOC);
This would be better as:
scb_data->scbarray = kcalloc(AHC_SCB_MAX_ALLOC, sizeof(struct scb), GFP_ATOMIC)
without the memset.
| |