Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 08 Nov 2010 08:04:49 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH] x86-64: more fixes and cleanup to AMD Fam10 MMCONF enabling |
| |
>>> On 05.11.10 at 18:51, Yinghai Lu <yinghai@kernel.org> wrote: > On 11/05/2010 03:59 AM, Jan Beulich wrote: >> Unfortunately it turned out the original code had more issues: We want >> to place the region above 4G in any case (even if TOM2 isn't enabled >> or invalid), and the base mask definition was improperly typed (thus >> causing shifts by FAM10H_MMIO_CONF_BASE_SHIFT to produce other than >> the intended result). Fixing this in turn allowed simplifying the MMIO >> region detection code, as regions ending below TOM2 now aren't of >> interest anymore. >> >> This will only apply cleanly on top of yesterday's patch titled >> "x86-64: fix and clean up AMD Fam10 MMCONF enabling". > > I don't think we have systems that have Enable bit set, but TOM2 < 4G.
I suppose that's true, but making the kernel independent of BIOS flaws (especially when it's that cheap) seems like a good idea to me. But of course, if that's what would be hindering acceptance of the patch, I'd re-submit with that part dropped.
Jan
| ![\](/images/icornerr.gif) |