lkml.org 
[lkml]   [2010]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/9] Add yaffs allocator, bitmap and attrib source
Date
On Friday 05 November 2010 12:01:07 Jesper Juhl wrote:
> On Thu, 4 Nov 2010, cdhmanning@gmail.com wrote:
> [snip]
>
> > +void yaffs_free_raw_obj(struct yaffs_dev *dev, struct yaffs_obj *obj)
> > +{
> > +
> > + struct yaffs_allocator *allocator = dev->allocator;
> > +
> > + if (!allocator)
> > + YBUG();
> > + else {
> > + /* Link into the free list. */
> > + obj->siblings.next = (struct list_head
> > *)(allocator->free_objs); + allocator->free_objs = obj;
> > + allocator->n_free_objects++;
> > + }
> > +}
> > +
> > +void yaffs_deinit_raw_tnodes_and_objs(struct yaffs_dev *dev)
> > +{
> > + if (dev->allocator) {
> > + yaffs_deinit_raw_tnodes(dev);
> > + yaffs_deinit_raw_objs(dev);
> > +
> > + YFREE(dev->allocator);
> > + dev->allocator = NULL;
> > + } else
> > + YBUG();
> > +}
> > +
> > +void yaffs_init_raw_tnodes_and_objs(struct yaffs_dev *dev)
> > +{
> > + struct yaffs_allocator *allocator;
> > +
> > + if (!dev->allocator) {
> > + allocator = YMALLOC(sizeof(struct yaffs_allocator));
> > + if (allocator) {
> > + dev->allocator = allocator;
> > + yaffs_init_raw_tnodes(dev);
> > + yaffs_init_raw_objs(dev);
> > + }
> > + } else
> > + YBUG();
> > +}
>
> Tiny style issue; Documentation/CodingStyle says:
>
> "Do not unnecessarily use braces where a single statement will do.
>
> if (condition)
> action();
>
> This does not apply if one branch of a conditional statement is a single
> statement. Use braces in both branches.
>
> if (condition) {
> do_this();
> do_that();
> } else {
> otherwise();
> }
> "
>
> So, in the above, you should have curly braces around both the 'if' and
> 'else' parts since one of them is more than one statement.

Thanks Jesper

Aargh!! I had the code the right way and changed it! My bad for misreading
the CodingStyle.

I have corrected this for the next patch drop, probably a week out.

-- Charles


\
 
 \ /
  Last update: 2010-11-07 23:45    [W:0.116 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site