Messages in this thread | | | Date | Fri, 05 Nov 2010 08:02:34 -0400 | From | Mauro Carvalho Chehab <> | Subject | Re: [RFC PATCH 00/20] RAS daemon v3 |
| |
Hi Boris,
Em 04-11-2010 11:36, Borislav Petkov escreveu: > From: Borislav Petkov <borislav.petkov@amd.com> > > Hi all, > > I finally had some time to work on this thing again. This time it can > parse the MCE tracepoint and should be conceptually almost done. What > needs to be done now is fleshing out a bunch of details here and there. > I'm sending it early so that I can collect some more feedback. > > So the patchset is ontop of 2.6.36 + Steven's trace_cmd restructuring > set from > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git tip/perf/parse-events > > I'm adding his patches too here, for completeness (although they need > some more work).
I tried to apply your patches here, but they didn't apply. i suspect that Steven added some patches there at the meantime, as two patches on your series are already on his tree. IMO, the better would be if you could create a temporary tree or branch to allow us to better view it.
> I've also cherry-picked the bunch of EDAC's MCE injection stuff for > testing. > > So, in the end of the day, if you do > > echo 0x9c00410000010016 > /sys/devices/system/edac/mce/status > > (0x9c.. is the MCE signature of a data cache L2 TLB multimatch, for > example)
This example looks quite ugly to me. I doubt anyone without a datasheet and after a very careful inspection would know what 0x9c00410000010016 magic number means. I suspect that writing a wrong magic number will also produce a completely undesired result. So, the better it to keep the MCE code internally to the driver.
Also, writing a magic number to a node named as "status" seems weird to me.
IMO, instead, it should be something like:
echo 1 >/sys/devices/system/edac/mce/error_inject
> > echo 0 > /sys/devices/system/edac/mce/bank > > (0 means bank 0, i.e. data cache errors) > > after having loaded the mce_amd_inj injection testing module, the RAS > daemon get's the status signature in userspace: > > ... > DBG main: Read some mmapped data > DBG main: MCE status: 0x9c00410000010016 > > All of the remaining fields can be postprocessed in arbitrary manner > after that. The MCE decoding in the kernel can then be simplified by > sharing it with the daemon, if needed. But that's another story. >
| |