lkml.org 
[lkml]   [2010]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 0/1] x86: Eliminate bp argument from the stack tracing routines
Date
Hi,

This is a resurrection of an old patch that I sent about a year ago:

http://lkml.org/lkml/2009/10/22/192

At the time, I thought the patch broke perf callchains on 64 bit, but
it turns out that those are broken even without this patch.

I don't know why that is, but I now think the patch is correct and to
blame.

(FWIW, this

diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
index 461a85d..d977d26 100644
--- a/arch/x86/kernel/cpu/perf_event.c
+++ b/arch/x86/kernel/cpu/perf_event.c
@@ -1653,7 +1653,7 @@ static const struct stacktrace_ops backtrace_ops = {
.warning_symbol = backtrace_warning_symbol,
.stack = backtrace_stack,
.address = backtrace_address,
- .walk_stack = print_context_stack_bp,
+ .walk_stack = print_context_stack,
};

makes it produce correct kernel callchains. And yes, I did compile the
kernel with CONFIG_FRAME_POINTER).

Soren




\
 
 \ /
  Last update: 2010-11-05 12:19    [W:0.158 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site