Messages in this thread | | | Subject | Re: [RFC PATCH 1/1] vhost: TX used buffer guest signal accumulation | From | Shirley Ma <> | Date | Thu, 04 Nov 2010 14:37:23 -0700 |
| |
On Thu, 2010-11-04 at 11:30 +0200, Michael S. Tsirkin wrote: > One thing to note is that deferred signalling needs to be > benchmarked with old guests which don't orphan skbs on xmit > (or disable orphaning in both networking stack and virtio-net).
Yes, we need run more test.
> > OK, so I guess I'll queue the __put_user etc patches for net-next, on > top of this > I think a patch which defers signalling would be nice to have, > then we can figure out whether a separate heads array still has > benefits > for non zero copy case: if yes what they are, if no whether it should > be > used for zero copy only for both both non-zero copy and zero copy. > > Makes sense?
Agree.
Shirley
| |