Messages in this thread | | | Date | Thu, 4 Nov 2010 20:47:46 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH v2] POWER: Add gpio charger driver |
| |
On Thu, Oct 28, 2010 at 02:17:41PM -0700, Rhyland Klein wrote: [...] > > Hm... I guess it can be, but on the other hand most platform bus chargers > > type > > devices can be, because the pda_power driver is keep pretty generic with > > custom init, > > status and exit callbacks. > > > > - Lars > > I didn't see any more discussion on this. Is the plan to integrate > the gpio-charger driver as is or to instead try to integrate support > for this into pda_power?
Sorry for the delayed response, and thanks for the pings! ;-)
The main thing I'm afraid of is duplication. I.e. someday you will want debouncing (include/linux/pda_power.h's wait_for_status, wait_for_charger parameters) support, regulators support etc.
And your gpio driver will look very similar to pda_power.
So I'd vote for adding the GPIO functionality to pda_power, and refactoring it if needed.
Though, if there are strong objections against this idea, I can merge the GPIO driver, and let's see how things will evolve.
Thanks!
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2
| |