Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 4 Nov 2010 15:35:40 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] irq: better struct irqaction layout |
| |
On Thu, Nov 04, 2010 at 11:13:48AM +0100, Eric Dumazet wrote: > We currently use kmalloc-96 slab for struct irqaction allocations on > 64bit arches. > > This is unfortunate because of possible false sharing and two cache > lines accesses. > > Move 'name' and 'dir' fields at the end of the structure, and force a > suitable alignement. > > Hot path fields now use one cache line on x86_64.
Looks good. It would be nice if some of the fields could be merged (like thread_flags and flags), but I assume it would be tought to get it back to 64 bytes again.
Reviewed-by: Andi Kleen <ak@linux.intel.com> -Andi
| ![\](/images/icornerr.gif) |