lkml.org 
[lkml]   [2010]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irq: better struct irqaction layout
On Thu, Nov 04, 2010 at 11:13:48AM +0100, Eric Dumazet wrote:
> We currently use kmalloc-96 slab for struct irqaction allocations on
> 64bit arches.
>
> This is unfortunate because of possible false sharing and two cache
> lines accesses.
>
> Move 'name' and 'dir' fields at the end of the structure, and force a
> suitable alignement.
>
> Hot path fields now use one cache line on x86_64.

Looks good. It would be nice if some of the fields could be merged (like
thread_flags and flags), but I assume it would be tought to get it back
to 64 bytes again.

Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi


\
 
 \ /
  Last update: 2010-11-04 15:39    [W:2.074 / U:1.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site