Messages in this thread | ![/](/images/icornerl.gif) | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/2] exec: copy-and-paste the fixes into compat_do_execve() paths | Date | Wed, 1 Dec 2010 12:04:33 +0900 (JST) |
| |
> Note: this patch targets 2.6.37 and tries to be as simple as possible. > That is why it adds more copy-and-paste horror into fs/compat.c and > uglifies fs/exec.c, this will be cleanuped later. > > compat_copy_strings() plays with bprm->vma/mm directly and thus has > two problems: it lacks the RLIMIT_STACK check and argv/envp memory > is not visible to oom killer. > > Export acct_arg_size() and get_arg_page(), change compat_copy_strings() > to use get_arg_page(), change compat_do_execve() to do acct_arg_size(0) > as do_execve() does. > > Add the fatal_signal_pending/cond_resched checks into compat_count() and > compat_copy_strings(), this matches the code in fs/exec.c and certainly > makes sense. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Looks good to me. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| ![\](/images/icornerr.gif) |