Messages in this thread Patch in this message | | | Date | Wed, 01 Dec 2010 09:33:25 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] btrfs: Correct printing of sector_t |
| |
Geert Uytterhoeven wrote: > If CONFIG_LBDAF=y, `sector_t' becomes `u64' instead of `unsigned long': > > fs/btrfs/inode.c: In function ‘btrfs_end_dio_bio’: > fs/btrfs/inode.c:5717: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 4 has type ‘sector_t’ > > Hence always cast it to `unsigned long long' for printing. > > Introduced by commit e65e1535542931e51189832264cd282e5899e4b9 ("btrfs: fix > panic caused by direct IO") > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
While we are at this..
===================
[PATCH] btrfs: Fix compile warning when CONFIG_MIGRATION is not set
Fix this newly introduced warning:
fs/btrfs/disk-io.c:699: warning: 'btree_migratepage' defined but not used
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- fs/btrfs/disk-io.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 33b6d45..7648247 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -696,6 +696,7 @@ static int btree_submit_bio_hook(struct inode *inode, int rw, struct bio *bio, __btree_submit_bio_done); } +#ifdef CONFIG_MIGRATION static int btree_migratepage(struct address_space *mapping, struct page *newpage, struct page *page) { @@ -712,12 +713,10 @@ static int btree_migratepage(struct address_space *mapping, if (page_has_private(page) && !try_to_release_page(page, GFP_KERNEL)) return -EAGAIN; -#ifdef CONFIG_MIGRATION + return migrate_page(mapping, newpage, page); -#else - return -ENOSYS; -#endif } +#endif static int btree_writepage(struct page *page, struct writeback_control *wbc) { -- 1.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |