lkml.org 
[lkml]   [2010]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 6/8] TILER-DMM: Geometry and view manipulation functions
On Tue, Nov 30, 2010 at 01:58:57PM -0600, David Sin wrote:
> From: Lajos Molnar <molnar@ti.com>
>
> This patch contains information on TILER geometry, as well as
> tiler_view_t object manipulation functions.
>
> It also contains an internal TILER header file to share geometric
> information with other TILER files.
>
> Signed-off-by: Lajos Molnar <molnar@ti.com>
> Signed-off-by: David Sin <davidsin@ti.com>
> ---
> drivers/misc/tiler/_tiler.h | 48 +++++

Ick, no, just name it "tiler.h" please. There should not be any need to
put _ in front of a .h file.

> +u32 tiler_bpp(const struct tiler_block_t *b)
> +{
> + enum tiler_fmt fmt = tiler_fmt(b->phys);
> + BUG_ON(fmt == TILFMT_INVALID || fmt == TILFMT_PAGE);

Don't cause the kernel to crash within a driver for no good reason like
this. Please fix these to WARN_ON if it's really something that can
happen.

If not, then just remove it.

> +
> + return geom[fmt].bpp;
> +}
> +EXPORT_SYMBOL(tiler_bpp);

EXPORT_SYMBOL_GPL() perhaps for all of these?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-12-01 02:05    [W:0.084 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site