Messages in this thread | | | Date | Tue, 30 Nov 2010 14:23:38 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 1/3] Move zone_reclaim() outside of CONFIG_NUMA |
| |
On Tue, 30 Nov 2010 15:45:12 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> This patch moves zone_reclaim and associated helpers > outside CONFIG_NUMA. This infrastructure is reused > in the patches for page cache control that follow. >
Thereby adding a nice dollop of bloat to everyone's kernel. I don't think that is justifiable given that the audience for this feature is about eight people :(
How's about CONFIG_UNMAPPED_PAGECACHE_CONTROL?
Also this patch instantiates sysctl_min_unmapped_ratio and sysctl_min_slab_ratio on non-NUMA builds but fails to make those tunables actually tunable in procfs. Changes to sysctl.c are needed.
> Reviewed-by: Christoph Lameter <cl@linux.com>
More careful reviewers, please.
| |