Messages in this thread | | | Subject | Re: [thisops uV3 07/18] highmem: Use this_cpu_xx_return() operations | From | Peter Zijlstra <> | Date | Tue, 30 Nov 2010 20:38:30 +0100 |
| |
On Tue, 2010-11-30 at 20:29 +0100, Eric Dumazet wrote: > > well maybe a single prototype ;) > > static inline void kmap_atomic_idx_pop(void) > { > #ifdef CONFIG_DEBUG_HIGHMEM > int idx = __this_cpu_dec_return(__kmap_atomic_idx); > BUG_ON(idx < 0); > #else > __this_cpu_dec(__kmap_atomic_idx); > #endif > }
Right, at least a consistent prototype, the above looks fine to me.
| |