Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 30 Nov 2010 21:22:51 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cache smp_processor_id() in setup_local_APIC() |
| |
On Tue, Nov 30, 2010 at 07:11:45PM +0100, Tejun Heo wrote: > This is a trivial clean up. > > * Move initialization of @cpu inside preemption disabled region as > suggested by Cyrill Gorcunov. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Yinghai Lu <yinghai@kernel.org> > Cc: Cyrill Gorcunov <gorcunov@gmail.com> > --- > Alright, updated yet again, but I frankly don't see the point in these
code structure, if we would be referring variable taken inside preempt off this always look suspicious, i think you agree with me :)
> changes. If setup_local_APIC() is being run from a different CPU, we > have a much larger problem. We're already accessing cpu local > resources (tsc, lapic) outside of preemption disabled area. But, > anyways, I don't think it matters one way or the other. > > Thanks. >
| ![\](/images/icornerr.gif) |