Messages in this thread | | | Date | Wed, 3 Nov 2010 18:50:13 -0700 (PDT) | From | David Rientjes <> | Subject | Re:[PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus |
| |
On Thu, 4 Nov 2010, Figo.zhang wrote:
> > > CAP_SYS_RESOURCE also had better get 3% bonus for protection. > > > > > > > > > Would you like to elaborate as to why? > > > > > > process with CAP_SYS_RESOURCE capibility which have system resource > limits, like journaling resource on ext3/4 filesystem, RTC clock. so it > also the same treatment as process with CAP_SYS_ADMIN. >
NACK, there's no justification that these tasks should be given a 3% memory bonus in the oom killer heuristic; in fact, since they can allocate without limits it is more important to target these tasks if they are using an egregious amount of memory. CAP_SYS_RESOURCE threads have the ability to lower their own oom_score_adj values, thus, they should protect themselves if necessary like everything else.
| |