Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 3 Nov 2010 17:07:41 +0100 | From | Florian Mickler <> | Subject | Re: [PATCH] checkpatch.pl: fix CAST detection to not screw with parens handling |
| |
On Wed, 3 Nov 2010 16:26:44 +0100 Audun Hoem <audun.hoem@gmail.com> wrote:
> On 11/3/10, Florian Mickler <florian@mickler.org> wrote: > > On Wed, 3 Nov 2010 13:04:33 +0100 > > Florian Mickler <florian@mickler.org> wrote: > > > >> Casts have to be handled after the last type that is followed by an > >> opening parenthesis is handled. > > > > That is the wrong fix. I realized now that with that patch we would > > not claim anything as a CAST anymore. Better is probably to only claim > > a CAST if av_pending is not set. Andy, would that work? It seems to be > > alright... Do you have some tests for checkpatch? > > > > Testing it with the reported line and some other random samples it > > seems to be alright. > > > > Probably good enough of a test to try it on random kernel code.
Yes, on random inspection of kernel code the new output looks good. (I've set dbg_values to 2 and diffed the output for some files of the patched version with the output of the broken version)
I speculated on Andy to have a special set of problematic test cases, but I looked through the git-log of checkpatch and tested some of the stuff there. It all seems ok.
Regards, Flo
| ![\](/images/icornerr.gif) |