Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 3 Nov 2010 10:44:29 -0400 (EDT) | From | Jiri Kosina <> | Subject | Re: Resend [PATCH 3/4] MacbookAir3,1 and 3,2 hid support |
| |
On Wed, 3 Nov 2010, gimli wrote:
> > On Wed, 3 Nov 2010 09:56:21 -0400 (EDT), Jiri Kosina <jkosina@suse.cz> > wrote: > > On Wed, 3 Nov 2010, gimli wrote: > > > >> Does this look better ? > > > > What I would actually prefer would be something like > > > > > > if ( ... ) > > table = macbookair_fn_keys; > > else if ( ... ) > > table = powerbook_fn_keys; > > else > > table = apple_fn_keys; > > > > apple_find_translation(table, usage->code); > > > >> I also use the USB id's for the if. > Next try.
I have slightly modified the code to be more like what I proposed above, and applied the patch. Thanks a lot,
-- Jiri Kosina SUSE Labs, Novell Inc.
| ![\](/images/icornerr.gif) |