Messages in this thread | | | Date | Mon, 29 Nov 2010 13:50:30 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/2] TTY: ldisc, fix open flag handling |
| |
On Thu, Nov 25, 2010 at 12:27:54AM +0100, Jiri Slaby wrote: > When a concrete ldisc open fails in tty_ldisc_open, we forget to clear > TTY_LDISC_OPEN. This causes a false warning on the next ldisc open: > WARNING: at drivers/char/tty_ldisc.c:445 tty_ldisc_open+0x26/0x38() > Hardware name: System Product Name > Modules linked in: ... > Pid: 5251, comm: a.out Tainted: G W 2.6.32-5-686 #1 > Call Trace: > [<c1030321>] ? warn_slowpath_common+0x5e/0x8a > [<c1030357>] ? warn_slowpath_null+0xa/0xc > [<c119311c>] ? tty_ldisc_open+0x26/0x38 > [<c11936c5>] ? tty_set_ldisc+0x218/0x304 > ... > > So clear the bit when failing... > > Introduced in c65c9bc3efa (tty: rewrite the ldisc locking) back in > 2.6.31-rc1. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Alan Cox <alan@linux.intel.com> > Reported-by: Sergey Lapin <slapin@ossfans.org> > Tested-by: Sergey Lapin <slapin@ossfans.org>
Is this still needed, or can I just use your: [PATCH v2 1/2] TTY: don't allow reopen when ldisc is changing patch instead?
thanks,
greg k-h
| |