Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 29 Nov 2010 11:43:22 -0800 | From | Greg KH <> | Subject | Re: [PATCH 4/6] staging: ft1000: Remove unused headers. |
| |
On Tue, Nov 23, 2010 at 01:29:31PM +0100, Marek Belisko wrote: > Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com> > --- > drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > index 8d2c059..3df4b4c 100644 > --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > @@ -24,23 +24,14 @@ > // 6/05/06 Whc Porting to Linux 2.6.9 > // > //--------------------------------------------------------------------------- > -#include <linux/module.h> > -#include <linux/kernel.h> > #include <linux/sched.h>
Odds are you do want module.h and kernel.h but not sched.h, right?
> -#include <linux/signal.h> > -#include <linux/errno.h>
You have no error numbers in this driver? I doubt that.
> #include <linux/poll.h> > #include <linux/netdevice.h> > #include <linux/delay.h> > #include <linux/miscdevice.h> > - > -#include <linux/fs.h> > -#include <linux/kmod.h>
These can be removed.
> #include <linux/ioctl.h> > -#include <linux/unistd.h>
As can this.
thanks,
greg k-h
| ![\](/images/icornerr.gif) |