Messages in this thread | | | Date | Mon, 29 Nov 2010 13:57:05 +0100 | From | Pavel Machek <> | Subject | Re: ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy) |
| |
Hi!
> > ...so I indentified two endianness problems in eeprom, but even with > > both fixed, it still will not associate. Is there some way to dump USB > > packets, then compare them between PC and PowerPC versions? Should I > > expect them to match? > > Does this patch help ?
Actually I wonder...
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c > index e9761c2..1b435d4 100644 > --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c > @@ -204,7 +204,7 @@ static int ath9k_htc_add_station(struct ath9k_htc_priv *priv, > ista = (struct ath9k_htc_sta *) sta->drv_priv; > memcpy(&tsta.macaddr, sta->addr, ETH_ALEN); > memcpy(&tsta.bssid, common->curbssid, ETH_ALEN); > - tsta.associd = common->curaid; > + tsta.associd = cpu_to_be16(common->curaid); > tsta.is_vif_sta = 0; > tsta.valid = true; > ista->index = priv->nstations;
We know the code currently works on PC; but this adds conversions that are nop on PowerPC and do something on PC... so they should have no effect on PowerPC and could break PC...? Pavel
| |