Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 27 Nov 2010 11:23:15 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH] sh: boards: mach-se: use IS_ERR() instead of NULL check |
| |
On Fri, Nov 26, 2010 at 08:45:33PM +0300, Vasiliy Kulikov wrote: > Hi Guennadi, > > On Fri, Nov 26, 2010 at 18:38 +0100, Guennadi Liakhovetski wrote: > > On Fri, 26 Nov 2010, Vasiliy Kulikov wrote: > > > clk_get() returns ERR_PTR() on error, not NULL. > > > > > > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> > > > > Yep, there are, probably, a couple more of these, similar to > > I found a bit more, but I'd like to get feedback on these or just see it > applied first ;) > It's a reasonable change, yes. The old clk_get() scanned multiple lists, and could return NULL or -ENOENT depending on which path failed. Now that everything is consolidated through the clk_get_sys() lookup, the NULL checks should probably all be replaced.
| ![\](/images/icornerr.gif) |